Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't attach comments with mismatched indents #12604

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Don't attach comments with mismatched indents #12604

merged 1 commit into from
Aug 1, 2024

Conversation

charliermarsh
Copy link
Member

Summary

Given:

def test_update():
    pass
    # comment
def test_clientmodel():
    pass

We don't want # comment to be attached to def test_clientmodel().

Closes #12589.

@charliermarsh charliermarsh added the bug Something isn't working label Aug 1, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) August 1, 2024 01:57
@charliermarsh charliermarsh disabled auto-merge August 1, 2024 01:58
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh charliermarsh merged commit 7e6b190 into main Aug 1, 2024
20 checks passed
@charliermarsh charliermarsh deleted the charlie/start branch August 1, 2024 02:09
@BrewTestBot BrewTestBot mentioned this pull request Aug 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fixing file with rules E302, E303 cause infinite loop
1 participant
@charliermarsh