Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[red-knot] unswap naming of benchmark groups #12396

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

carljm
Copy link
Contributor

@carljm carljm commented Jul 18, 2024

Unless there's some logic in criterion_group! that I really don't understand, it looks like these benchmark group names were swapped, so the group labeled without_parse was actually the cold benchmark, and vice versa. Not sure this practically matters, since the benchmark function names were correct.

Copy link

codspeed-hq bot commented Jul 18, 2024

CodSpeed Performance Report

Merging #12396 will not alter performance

Comparing cjm/fix-benchmark-naming (d901769) with cjm/bench-preparse-builtins (93cf6b5)

Summary

✅ 31 untouched benchmarks

🆕 2 new benchmarks
⁉️ 2 (👁 2) dropped benchmarks

Benchmarks breakdown

Benchmark cjm/bench-preparse-builtins cjm/fix-benchmark-naming Change
🆕 red_knot_check_file[cold] N/A 346.1 µs N/A
👁 red_knot_check_file[without_parse] 257 µs N/A N/A
👁 red_knot_check_file[cold] 343.9 µs N/A N/A
🆕 red_knot_check_file[without_parse] N/A 258.4 µs N/A

@carljm carljm changed the title [red-knot] fix naming of benchmarks [red-knot] unswap naming of benchmark groups Jul 18, 2024
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser MichaReiser merged commit 95404a4 into cjm/bench-preparse-builtins Jul 19, 2024
20 checks passed
@MichaReiser MichaReiser deleted the cjm/fix-benchmark-naming branch July 19, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants