Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flake8-async] Update ASYNC115 to match upstream #12262

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

augustelalande
Copy link
Contributor

@augustelalande augustelalande commented Jul 10, 2024

Summary

Update the name of ASYNC115 to match upstream.

Also update the functionality to match upstream by adding support for anyio (gated behind preview). asyncio does not have a lowlevel.checkpoint equivalent.

This resolves #12039.

Test Plan

Added tests for anyio

Copy link

codspeed-hq bot commented Jul 10, 2024

CodSpeed Performance Report

Merging #12262 will not alter performance

Comparing augustelalande:async115 (f0ec230) with main (0bb2fc6)

Summary

✅ 33 untouched benchmarks

@MichaReiser MichaReiser added the preview Related to preview mode features label Jul 10, 2024
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you. If I understand the PR correctly then it's also adding support for (trio|anyio).sleep. We should gate this change behind preview, the same as for the other PRs.

@MichaReiser
Copy link
Member

If I understand the PR correctly then it's also adding support for (trio|anyio).sleep. We should gate this change behind preview, the same as for the other PRs.

Sorry, I'm blind

@MichaReiser MichaReiser merged commit d365f1a into astral-sh:main Jul 10, 2024
20 checks passed
@augustelalande augustelalande deleted the async115 branch July 10, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Related to preview mode features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add asyncio and anyio support to ASYNC1XX
2 participants