Disable auto-fix when source has syntax errors #12134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dhruvmanila
force-pushed
the
dhruv/disable-autofix
branch
from
3390bf0 to
b58e87b
Compare
charliermarsh
approved these changes
Jul 1, 2024
MichaReiser
approved these changes
Jul 2, 2024
Comment on lines
-291
to
-296
| // Remove fixes for any rules marked as unfixable. | ||
| for diagnostic in &mut diagnostics { | ||
| if !settings.rules.should_fix(diagnostic.kind.rule()) { | ||
| diagnostic.fix = None; | ||
| if parsed.is_valid() { | ||
| // Remove fixes for any rules marked as unfixable. | ||
| for diagnostic in &mut diagnostics { | ||
| if !settings.rules.should_fix(diagnostic.kind.rule()) { | ||
| diagnostic.fix = None; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I wasn't aware that we already had a similar loop. I guess this is okay. It does have the downside that we waste time on generating fixes that we then just omit. But I see why we do it this way, because we lack a better abstraction for testing if a fix should be generated.
dhruvmanila
added a commit
that referenced
this pull request
Jul 4, 2024
## Summary This PR avoids the error notification if a user selects the source code actions and there's a syntax error in the source. Before #12134, the change would've been different. But that PR disables generating fixes if there's a syntax error. This means that we can return an empty map instead as there won't be any fixes in the diagnostics returned by the `lint_fix` function. For reference, following are the screenshot as on `main` with the error: **VS Code:** <img width="1715" alt="Screenshot 2024-07-02 at 16 39 59" src="https://github.com/astral-sh/ruff/assets/67177269/62f3e99b-0b0c-4608-84a2-26aeabcc6933"> **Neovim:** <img width="1717" alt="Screenshot 2024-07-02 at 16 38 50" src="https://github.com/astral-sh/ruff/assets/67177269/5d637c36-d7f8-4a3b-8011-9a89708919a8"> fixes: #11931 ## Test Plan Considering the following code snippet where there are two diagnostics (syntax error and useless semicolon `E703`): ```py x; y = ``` ### VS Code https://github.com/astral-sh/ruff/assets/67177269/943537fc-ed8d-448d-8a36-1e34536c4f3e ### Neovim https://github.com/astral-sh/ruff/assets/67177269/4e6f3372-6e5b-4380-8919-6221066efd5b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates Ruff to not generate auto-fixes if the source code contains syntax errors as determined by the parser.
The main motivation behind this is to avoid infinite autofix loop when the token-based rules are run over any source with syntax errors in #11950.
Although even after this, it's not certain that there won't be an infinite autofix loop because the logic might be incorrect. For example, #12094 and #12136.
This requires updating the test infrastructure to not validate for fix availability status when the source contained syntax errors. This is required because otherwise the fuzzer might fail as it uses the test function to run the linter and validate the source code.
resolves: #11455
Test Plan
cargo insta test