Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruff server: Add tracing setup guide to Helix documentation #11883

Merged
merged 5 commits into from
Jun 18, 2024
Merged

ruff server: Add tracing setup guide to Helix documentation #11883

merged 5 commits into from
Jun 18, 2024

Conversation

snowsignal
Copy link
Contributor

@snowsignal snowsignal commented Jun 14, 2024 •
edited
Loading

A follow-up to this suggestion on the tracing PR.

@snowsignal snowsignal added documentation Improvements or additions to documentation server Related to the LSP server labels Jun 14, 2024
@MichaReiser MichaReiser requested review from dhruvmanila and removed request for dhruvmanila June 15, 2024 08:09
MichaReiser
MichaReiser approved these changes Jun 15, 2024
View reviewed changes
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Does ruff log the messages to the default location in helix? Do users know where to find the logs?

crates/ruff_server/docs/setup/HELIX.md Outdated Show resolved Hide resolved
dhruvmanila
dhruvmanila approved these changes Jun 17, 2024
View reviewed changes
crates/ruff_server/docs/setup/HELIX.md Outdated Show resolved Hide resolved
@snowsignal
Copy link
Contributor Author

@MichaReiser

Does ruff log the messages to the default location in helix? Do users know where to find the logs?

Yes, by default it logs them to the Helix log file, which can be opened with :log-open.

@snowsignal snowsignal enabled auto-merge (squash) June 18, 2024 03:38
@snowsignal snowsignal merged commit c53d55a into main Jun 18, 2024
19 checks passed
@snowsignal snowsignal deleted the jane/server/docs/hx/trace branch June 18, 2024 03:41
@snowsignal snowsignal mentioned this pull request Jun 18, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation server Related to the LSP server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snowsignal @MichaReiser @dhruvmanila