Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Q003 to AST checker #10923

Merged
merged 1 commit into from
Apr 14, 2024
Merged

Move Q003 to AST checker #10923

merged 1 commit into from
Apr 14, 2024

Conversation

dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Apr 14, 2024 •
edited
Loading

Summary

This PR moves the Q003 rule to AST checker.

This is the final rule that used the docstring detection state machine and thus this PR removes it as well.

resolves: #7595
resolves: #7808

Test Plan

  • cargo test
  • Make sure there are no changes in the ecosystem

@dhruvmanila dhruvmanila added the internal An internal refactor or improvement label Apr 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 14, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@dhruvmanila dhruvmanila marked this pull request as ready for review April 14, 2024 16:39
@dhruvmanila dhruvmanila merged commit f9a828f into main Apr 14, 2024
17 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/move-q003 branch April 14, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
internal An internal refactor or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify Q003 implementation First string token is always considered as docstring
2 participants
@dhruvmanila @charliermarsh