Always place non-relative imports after relative imports #10669
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When
relative-imports-order = "closest-to-furthest"
is set, we should still put non-relative imports after relative imports. It's rare for them to be in the same section, but possible if you useknown-local-folder
.Closes #10655.
Test Plan
New tests.
Also sorted this file:
With both:
isort view.py
ruff check view.py --select I --fix
And the following
pyproject.toml
:I verified that Ruff and isort gave the same result, and that they still gave the same result when removing the relevant setting: