Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of SCARY SECURITY suffixes for security-related renovate PRs #10579

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

AlexWaygood
Copy link
Member

Just use a security label instead

@AlexWaygood
Copy link
Member Author

See e.g. the PR title in #10577 for what we're trying to avoid... docs here: https://docs.renovatebot.com/configuration-options/#vulnerabilityalerts

@AlexWaygood AlexWaygood requested a review from zanieb March 25, 2024 17:47
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) thanks

@AlexWaygood AlexWaygood merged commit bd07c13 into main Mar 25, 2024
17 checks passed
@AlexWaygood AlexWaygood deleted the scary-security-prs branch March 25, 2024 17:57
],
"vulnerabilityAlerts": {
"commitMessageSuffix": "",
"labels": ["internal", "security"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo doesn't have security label. renovatebot couldn't add this label to its PRs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure it would have just created one, but I've created one just to be sure: security Related to security vulnerabilities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants