Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid code comment detection in PEP 723 script tags #10464

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

charliermarsh
Copy link
Member

Closes #10455.

@charliermarsh charliermarsh added the bug Something isn't working label Mar 18, 2024
@charliermarsh charliermarsh marked this pull request as ready for review March 18, 2024 21:33
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+0 -2 violations, +0 -0 fixes in 1 projects; 42 projects unchanged)

apache/airflow (+0 -2 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --no-preview --select ALL

- clients/python/test_python_client.py:21:1: ERA001 Found commented-out code
- clients/python/test_python_client.py:24:1: ERA001 Found commented-out code

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
ERA001 2 0 2 0 0

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+0 -2 violations, +0 -0 fixes in 1 projects; 42 projects unchanged)

apache/airflow (+0 -2 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

- clients/python/test_python_client.py:21:1: ERA001 Found commented-out code
- clients/python/test_python_client.py:24:1: ERA001 Found commented-out code

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
ERA001 2 0 2 0 0

@charliermarsh
Copy link
Member Author

Ecosystem change is a real false positive.

@charliermarsh charliermarsh merged commit 938118b into main Mar 18, 2024
17 checks passed
@charliermarsh charliermarsh deleted the charlie/script branch March 18, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some lines in PEP 723 blocks trigger ERA001
1 participant