[flake8-pytest-style] Add automatic fix for pytest-parametrize-values-wrong-type (PT007)

[autinerd]

Summary

This adds automatic fixes for the PT007 rule.

I am currently reviewing and adding Ruff rules to Home Assistant. One rule is PT007, which has multiple hundred occurrences in the codebase, but no automatic fix, and this is not fun to do manually, especially because using Regexes are not really possible with this.

My knowledge of the Ruff codebase and Rust in general is not good and this is my first PR here, so I hope it is not too bad.

One thing where I need help is: How can I have the transformed code to be formatted automatically, instead of it being minimized as it does it now?

Test Plan

Using the existing fixtures and updated snapshots.

[charliermarsh]

Thanks for this!

One thing where I need help is: How can I have the transformed code to be formatted automatically, instead of it being minimized as it does it now?

So, if you want to do this, you can't use generator. The generator is just a basic printer that takes an AST and prints it without formatting. If you want to preserve the existing formatting (including comments), you need to implement a more manual fix (e.g., change the [ to ( and the ] to ), or similar). Check out unnecessary_generator_set for an example of what that might look like.

I'm fine to merge with the generator-based fix, though a locator-based fix tends to preserve more of this kind of trivia. Are you interested in trying it?

[autinerd]

Oh yes, I see it now that this approach deletes all comments. Thanks for pointing me to a place to check, I will try if I can do this.

[charliermarsh]

Yeah it's kind of a tradeoff. The generator is much easier (to program, and to get right), but much lower-fidelity.

[github-actions]

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

[autinerd]

So, I have it now as a locator-based fix based of unnecessary_generator_set, thanks!

It also checks if a list has only 1 element and transforms ["test"] into ("test",) to make it a valid tuple.

The only thing is that ("test",) will be converted into ["test",], which is valid from the syntax, but of course not the most beautiful.

[autinerd]

And I have it now as a unsafe fix, but I think it should be safe to use in this approach.

[autinerd]

Oh, ruff-format seems to transform ["test",] unconditionally into

[
    "test",
]

Then maybe I need to remove the comma, because this disrupts the source formatting.

[charliermarsh]

You could, e.g., only remove the trailing comma if it immediately precedes the closing brace.

[autinerd]

I'm sorry, but can you maybe hint me on how to access the text of the Expr to that I can check on whether it ends with ,)?

Ah, I'm blind, I see it now.

[autinerd]

It doesn't look very elegant in my opinion, but it works.

[charliermarsh]

Thanks! I'll take a look now. I may tweak the locator usage a bit but it's generally what I was suggesting.

[charliermarsh]

Just one bugfix: the PR was adding a trailing comma here, which led to ,,