[flake8_comprehensions] Handled special case for C400 which also matches C416
#10419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| return; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I decided to just use more nesting here rather than the break pattern. It's not necessarily "better", just a matter of personal preference.
| ); | ||
| let Some(ExprGenerator { | ||
| elt, generators, .. | ||
| }) = argument.as_generator_expr() |
There was a problem hiding this comment.
.as_generator_expr() lets us avoid the clone.
charliermarsh
force-pushed
the
unnecessary-generator-list
branch
from
856331e to
1ca7107
Compare
charliermarsh
pushed a commit
that referenced
this pull request
Mar 26, 2024
…matches `C416` (#10596) ## Summary <!-- What's the purpose of the change? What does it do, and why? --> Similar to #10419, there was a case where there is a collision of C401 and C416 (as discussed in #10101). Fixed this by implementing short-circuit for the comprehension of the form `{x for x in foo}`. ## Test Plan <!-- How was it tested? --> Extended `C401.py` with the case where `set` is not builtin function, and divided the case where the short-circuit should occur. Removed the last testcase of `print(f"{ {set(a for a in 'abc')} }")` test as this is invalid as a python code, but should I keep this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Short-circuit implementation mentioned in #10403.
I implemented this by extending C400:
UnnecessaryGeneratorListhave information of whether the the short-circuiting occurred (to put diagnostic)unnecessary_generator_listfunction.Please give me suggestions if you think this isn't the best way to handle this :)
Test Plan
Extended
C400.pya little, and written the cases where:liste.g.list(x for x in range(3))->list(range(3))liste.g.list(2 * x for x in range(3))->[2 * x for x in range(3)]listfunction is not built-in, and should not modify the code in any way.