Track conditional deletions in the semantic model #10415
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Given
del X
, we'll typically add aBindingKind::Deletion
toX
to shadow the current binding. However, if the deletion is inside of a conditional operation, we won't, as in:We will, however, track it as a reference to the binding. This PR adds the expression context to those resolved references, so that we can detect that the
X
inglobal X
was "assigned to".Closes #10397.