Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid TRIO115 if the argument is a variable #10376

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Avoid TRIO115 if the argument is a variable #10376

merged 1 commit into from
Mar 13, 2024

Conversation

augustelalande
Copy link
Contributor

Summary

Fix "TRIO115 false positive with with sleep(var) where var starts as 0" #9935 based on the discussion in the issue.

Test Plan

Issue code added to fixture

@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

dhruvmanila
dhruvmanila approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dhruvmanila dhruvmanila added the bug Something isn't working label Mar 13, 2024
@dhruvmanila dhruvmanila changed the title Fix TRIO115 false positive #9935 Avoid TRIO115 if the argument is a variable Mar 13, 2024
@dhruvmanila dhruvmanila merged commit 93d582d into astral-sh:main Mar 13, 2024
17 checks passed
@augustelalande augustelalande deleted the trio115-false-positive branch March 13, 2024 13:40
@BrewTestBot BrewTestBot mentioned this pull request Mar 15, 2024
Merged
@robincaloudis robincaloudis mentioned this pull request Mar 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@augustelalande @dhruvmanila