Fix unstable with-items formatting

[MichaReiser]

Summary

Fixes #10267

The issue with the current formatting is that the formatter flips between the SingleParenthesizedContextManager and ParenthesizeIfExpands or SingleWithTarget because the layouts use incompatible formatting ( SingleParenthesizedContextManager: maybe_parenthesize_expression(context) vs ParenthesizeIfExpands: parenthesize_if_expands(item), SingleWithTarget: optional_parentheses(item).

The fix is to ensure that the layouts between which the formatter flips when adding or removing parentheses are the same. I do this by introducing a new SingleWithoutTarget layout that uses the same formatting as SingleParenthesizedContextManager if it has no target and prefer SingleWithoutTarget over using ParenthesizeIfExpands or SingleWithTarget.

Formatting change

The downside is that we now use maybe_parenthesize_expression over parenthesize_if_expands for expressions where can_omit_optional_parentheses returns false. This can lead to stable formatting changes. I only found one formatting change in our ecosystem check and, unfortunately, this is necessary to fix the instability (and instability fixes are okay to have as part of minor changes according to our versioning policy)

The benefit of the change is that with items with a single context manager and without a target are now formatted identically to how the same expression would be formatted in other clause headers.

Test Plan

I ran the ecosystem check locally

[github-actions]

ruff-ecosystem results

Formatter (stable)

ℹ️ ecosystem check detected format changes. (+2 -2 lines in 1 file in 1 projects; 42 projects unchanged)

rotki/rotki (+2 -2 lines across 1 file)

rotkehlchen/rotkehlchen.py~L1213

         if oracle != HistoricalPriceOracle.CRYPTOCOMPARE:
             return  # only for cryptocompare for now
 
-        with (
-            contextlib.suppress(UnknownAsset)
+        with contextlib.suppress(
+            UnknownAsset
         ):  # if suppress -> assets are not crypto or fiat, so we can't query cryptocompare  # noqa: E501
             self.cryptocompare.create_cache(
                 from_asset=from_asset,

Formatter (preview)

ℹ️ ecosystem check detected format changes. (+2 -2 lines in 1 file in 1 projects; 42 projects unchanged)

rotki/rotki (+2 -2 lines across 1 file)

ruff format --preview

rotkehlchen/rotkehlchen.py~L1211

         if oracle != HistoricalPriceOracle.CRYPTOCOMPARE:
             return  # only for cryptocompare for now
 
-        with (
-            contextlib.suppress(UnknownAsset)
+        with contextlib.suppress(
+            UnknownAsset
         ):  # if suppress -> assets are not crypto or fiat, so we can't query cryptocompare  # noqa: E501
             self.cryptocompare.create_cache(
                 from_asset=from_asset,

[aneeshusa]

I'm traveling today but am happy to give this a try tomorrow! Amazed how quick you put this together, thank you!

[charliermarsh]

Thanks @aneeshusa 👋

[aneeshusa]

Can't do a GitHub approval but tested this and this fixes both an isolated repro and the monorepo at $WORK! Would love to see this in a release.

[charliermarsh]

Just shipped this in v0.3.2 :)