Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Color entire line in Diffs #10183

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

senadev42
Copy link
Contributor

@senadev42 senadev42 commented Mar 1, 2024

Summary

Quick fix applying color to entire line rather than just symbols.

Changes this

image

to this

image

Test Plan

Tested on files that had full text lines changes and not just new lines/white space removed/added.

Follow up PR from #10110

Copy link
Contributor

github-actions bot commented Mar 1, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@senadev42 senadev42 marked this pull request as ready for review March 1, 2024 12:32
@MichaReiser MichaReiser added the cli Related to the command-line interface label Mar 1, 2024
@MichaReiser
Copy link
Member

Much better. Thank you

@MichaReiser MichaReiser changed the title apply color to entire line CLI: Color entire line in Diffs Mar 1, 2024
@MichaReiser MichaReiser merged commit c59d82a into astral-sh:main Mar 1, 2024
17 checks passed
nkxxll pushed a commit to nkxxll/ruff that referenced this pull request Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the command-line interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants