E203: Don't warn about single whitespace before tuple , #10094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
force-pushed
the
e203-tuple-whitespace
branch
from
80ac3d4 to
d068e8f
Compare
|
charliermarsh
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10041
This PR fixes an issue in the
E203rule where it disallowed whitespace before a:if the:was directly followed by a,:This conflicts with our formatter because it inserts a whitespace before the
:for all non simple expressions.This PR allows the whitespace before the colon if what follows after is a
,, the same as we already do today if the colon is directly followed by a].Test Plan
Added test