Set PowerPC Page Size to 64KB #10080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
approved these changes
Feb 22, 2024
|
@nwf could you try one of the power pc binaries from (either wheel or from binaries) and report back if they are now working for you? https://github.com/astral-sh/ruff/actions/runs/8005385997#artifacts I can't test it myself because I don't have a power pc cpu |
|
Much better, thanks! |
|
Awesome. Thank you @nwf for testing the change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10073
We had a similar issue with aarch64 and the fix was to increase the page size to 64KB: #3791 (comment)
This PR does the same for PowerPC because widely used PowerPC systems use a default page size of 64KB source
Test Plan
@nwf tested the built binary on their power pc