Detect literals with unary operators (UP018) #10060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
approved these changes
Feb 20, 2024
Comment on lines
231
to
234
| if unary { | ||
| if !matches!(literal_type, LiteralType::Int | LiteralType::Float) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Would you mind adding a comment why this check is necessary for unary only and add a test case that verifies that ruff early returns if it's an unary and neither an Int nor Float
There was a problem hiding this comment.
I moved this up into the match.
charliermarsh
force-pushed
the
UP018-fix
branch
from
2e1820c to
7d309e7
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10029.