Preserve multiline strings in code generator #10000
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR for #7799 posted for discussion. Minimally tested with
cargo dev round-trip
.Extending
ruff_python_literal
to know more about Python string literals (raw, triple, etc.) should be uncontroversial. Changes here are incomplete (no raw, universal newline, bytes...) but completing shouldn't be difficult.I am less sure about
ruff_python_codegen
changes. AST doesn't have enough information. Instead of adding needed information (after all, it's AST not CST), in this PRGenerator
has an optionalLocator
. WhenLocator
is available, string kind information is taken from original source and passed toruff_python_literal
. Behavior is unchanged ifLocator
is unavailable.