Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiline f-strings are not indexed as multiline strings #9777

Closed
sanxiyn opened this issue Feb 2, 2024 · 3 comments · Fixed by #9837
Closed

Multiline f-strings are not indexed as multiline strings #9777

sanxiyn opened this issue Feb 2, 2024 · 3 comments · Fixed by #9837
Assignees
@sanxiyn
Labels
bug Something isn't working

Comments

@sanxiyn
Copy link
Contributor

sanxiyn commented Feb 2, 2024

Tracking leftover work from #9744. Removing trailing whitespace inside multiline strings is unsafe, so multiline strings are indexed. But multiline f-strings are currently not indexed as multiline strings.
@dhruvmanila
Copy link
Member

Thanks for the issue! Are you interested in taking on the work required to complete this as you commented on the linked PR?

@dhruvmanila dhruvmanila added the bug Something isn't working label Feb 2, 2024
@sanxiyn
Copy link
Contributor Author

sanxiyn commented Feb 2, 2024

Yes, I want to try.

@dhruvmanila
Copy link
Member

Awesome! Feel free to ping me if you run into any issues :)

@sanxiyn sanxiyn mentioned this issue Feb 5, 2024
Merged
charliermarsh pushed a commit that referenced this issue Feb 6, 2024
@sanxiyn
Index multiline f-strings (#9837)
df7fb95 
Fix #9777.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanxiyn sanxiyn

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Index multiline f-strings sanxiyn/ruff
2 participants
@sanxiyn @dhruvmanila