-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
namespace-packages option stopped working in a recent update #9579
Comments
Hmm, I don't think we changed anything there in this version range. Are you able to share an example, including the configuration? It's possible that your old setup was working due to caching, since the INP rules have a bug related to caching (and upgrading your Ruff version would clear the cache). |
Here is a small example that reproduces the issue: https://github.com/gokay05/namespace-test When I run |
Thanks so much for putting together a repro! I'll take a look. |
Hm, something about specifying the config explicitly?
|
Ah sorry, this is indeed a bug, my fault. Thank you so much for filing! |
Fixed in #9603, will go out in the next release. |
## Summary When determining whether _any_ settings have namespace packages, we need to consider the global settings (as would be provided via `--config`). This was a subtle fallout of a refactor. Closes #9579. ## Test Plan Tested locally by compiling Ruff and running against this [namespace-test](https://github.com/gokay05/namespace-test) repo.
Thanks so much!! |
Thank you, I will always fix when there's a clear repro! |
When running Ruff with version 0.1.11, namespace-packages option excluded INP001 from being thrown. I recently updated Ruff to 0.1.13 and even though my ruff.toml hasnt changed, I am getting a bunch of INP001 from my test folders and such. I checked the website and I dont see anything change in terms of how the option works, so I think there might be a bug in the new version that effectively breaks namespace-packages.
The text was updated successfully, but these errors were encountered: