Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad contrast for hyperlinks on note blocks in the webpage #9046

Closed
MicaelJarniac opened this issue Dec 7, 2023 · 2 comments · Fixed by #9385
Closed

Bad contrast for hyperlinks on note blocks in the webpage #9046

MicaelJarniac opened this issue Dec 7, 2023 · 2 comments · Fixed by #9385
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@MicaelJarniac
Copy link
Contributor

image

https://docs.astral.sh/ruff/formatter/#ruff-format
@charliermarsh
Copy link
Member

Thanks!

@charliermarsh charliermarsh added bug Something isn't working documentation Improvements or additions to documentation labels Dec 7, 2023
@zanieb
Copy link
Member

zanieb commented Dec 8, 2023

Oh Dark mode.... :D

@Eutropios Eutropios mentioned this issue Jan 3, 2024
Merged
charliermarsh pushed a commit that referenced this issue Jan 4, 2024
@Eutropios
[docs] - Fix admonition hyperlink colouring (#9385)
1293383 
<!--
Thank you for contributing to Ruff! To help us out with reviewing,
please consider the following:

- Does this pull request include a summary of the change? (See below.)
- Does this pull request include a descriptive title?
- Does this pull request include references to any relevant issues?
-->

## Summary

<!-- What's the purpose of the change? What does it do, and why? -->
Fix the colouration of hyperlinks within admonitions on dark theme to be
more readable. Closes #9046

## Test Plan

<!-- How was it tested? -->
Documentation was regenerated via mkdocs and the supplied requirements.

Signed-off-by: [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[docs] - Fix admonition hyperlink colouring Eutropios/ruff
3 participants
@charliermarsh @zanieb @MicaelJarniac