Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: allow PLR0913 in @overriden methods #8945

Closed
ZeeD opened this issue Dec 1, 2023 · 3 comments · Fixed by #8954
Closed

feature request: allow PLR0913 in @overriden methods #8945

ZeeD opened this issue Dec 1, 2023 · 3 comments · Fixed by #8954
Assignees
@charliermarsh

Comments

@ZeeD
Copy link

ZeeD commented Dec 1, 2023

Basically same scenario of #8867 - in case of @override there is nothing I can do to simplify the signature of the method, so please ignore too-many-arguments (PLR0913) checks.
@ZeeD ZeeD changed the title feature request: allow PLR0913 in @overrided methods feature request: allow PLR0913 in @overriden methods Dec 1, 2023
@charliermarsh charliermarsh mentioned this issue Dec 1, 2023
Merged
@charliermarsh charliermarsh self-assigned this Dec 1, 2023
charliermarsh added a commit that referenced this issue Dec 1, 2023
@charliermarsh
Ignore @overload and @override methods for too-many-arguments che…
5510a61 
…cks (#8954)

Closes #8945.
@ZeeD
Copy link
Author

ZeeD commented Dec 3, 2023

Thanks!

@g-as
Copy link
Contributor

g-as commented Dec 4, 2023

Same should apply to newly added too-many-positional/PLR0917?

@charliermarsh
Copy link
Member

Yes, sorry, just an oversight. Fixed in #9000.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore @overload and @override methods for too-many-arguments checks astral-sh/ruff
3 participants
@ZeeD @charliermarsh @g-as