-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E203
conflicts with formatter (and black)
#8752
Comments
Is this consistent with PEP 8, though? I feel like it's in conflict with the PEP 8 guidelines (which is fine for the formatter, but the intent of the pycodestyle rules is to enforce PEP 8). Now I'm wondering if we should instead just mark the rule as incompatible, rather than trying to make it compatible with the formatter. |
PEP8 doesn't say anything about this.
This does not apply in our case: it concerns the space after the colon (where the parameter is omitted), not before the colon. How exactly you solve this, I don't really care. Using black right now, I'm preparing the switch to ruffs formatter and ideally, you would make that as painless as possible :) Disabling rules for this is fine. (Is there a selector to ignore all formatter-incompatible rules?) |
Hi, I think there is another case, where it is not working and that is when we have multiple indices, like in pandas: My example looks like this:
|
Incompatible with ruff ... astral-sh/ruff#8752
Rule
E203
still conflicts with ruff's own formatter:bug.py
bug.bat
Output:
Somewhat related to #7259 (but 0.1.5 behaves the same way, so likely #8654 did not break this, but instead should be extended to one-sided slices)
Potentially relevant for #7993
The text was updated successfully, but these errors were encountered: