Use the indent-width setting for E111 and E114

[NeilGirdhar]

E111 should probably use the indent-width setting?

[zanieb]

Hm it looks like these intentionally do not use this setting since there are notes about conflict with the formatter and they explicitly mention using a width of "4" in the documentation. I'm not sure I have the context to approve changing this. cc @charliermarsh / @MichaReiser

[charliermarsh]

I believe this is intentional since the pycodestyle rules are definitionally intended to adhere to PEP 8.

[zanieb]

Interestingly though, pycodestyle lets you configure the size.

[charliermarsh]

Oh, it does?

[charliermarsh]

Interesting.

[zanieb]

Here's a start #8708 — let me know if you're interested in writing the tests.

[charliermarsh]

I thought I merged something related to this recently, but I can't find it...

[charliermarsh]

Oh, I was thinking of #9506.

[asmaier]

There is also a documentation bug at https://docs.astral.sh/ruff/rules/#pycodestyle-e-w . It says

E111 Indentation is not a multiple of {indent_size}
...
E114 Indentation is not a multiple of {indent_size} (comment)

However in settings the variable is called indent-width, see https://docs.astral.sh/ruff/settings/#indent-width

[dhruvmanila]

There is also a documentation bug at docs.astral.sh/ruff/rules/#pycodestyle-e-w . It says

E111 Indentation is not a multiple of {indent_size}
...
E114 Indentation is not a multiple of {indent_size} (comment)

However in settings the variable is called indent-width, see docs.astral.sh/ruff/settings/#indent-width

Ah, that's because it's the name of the variable used internally:

ruff/crates/ruff_linter/src/rules/pycodestyle/rules/logical_lines/indentation.rs

Lines 76 to 87 in c391c8b

	#[violation]
	pub struct IndentationWithInvalidMultipleComment {
	indent_size: usize,
	}
	impl Violation for IndentationWithInvalidMultipleComment {
	#[derive_message_formats]
	fn message(&self) -> String {
	let Self { indent_size } = self;
	format!("Indentation is not a multiple of {indent_size} (comment)")
	}
	}

I think we should just rename that to indent_width. Do you want to open a PR for that? @asmaier

[charliermarsh]

Yeah let's just rename that variable.