Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request: external also matching prefixes #8174

Closed
jamesbraza opened this issue Oct 24, 2023 · 0 comments · Fixed by #8177
Closed

Request: external also matching prefixes #8174

jamesbraza opened this issue Oct 24, 2023 · 0 comments · Fixed by #8177
Assignees
@zanieb
Labels
configuration Related to settings and configuration

Comments

@jamesbraza
Copy link
Contributor

Coming from #8153 with ruff==0.1.1, there is the external setting for third party tools using noqa comments. It currently works solely on exact matching of the codes inside the list.

For tools like pydoclint, which has DOC error codes: jsh9/pydoclint#3-style-violation-codes, it would be useful if external worked using prefixes as well. That way, one could just have external = ["DOC"].

So the request is to have external also work using prefix matching (not just exact matching).
@jamesbraza jamesbraza mentioned this issue Oct 24, 2023
Closed
@zanieb zanieb mentioned this issue Oct 24, 2023
Closed
@zanieb zanieb added the configuration Related to settings and configuration label Oct 24, 2023
@zanieb zanieb mentioned this issue Oct 24, 2023
Merged
@zanieb zanieb self-assigned this Oct 24, 2023
zanieb added a commit that referenced this issue Oct 24, 2023
@zanieb
Match rule prefixes from external codes setting in unused-noqa (#…
6f31e9c 
…8177)

Supersedes #8176
Closes #8174

## Test plan

Old snapshot contains the new / unmatched `V` code
New snapshot contains no `V` prefixed codes
@Avasam Avasam mentioned this issue Oct 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanieb zanieb

Labels
configuration Related to settings and configuration
Projects
None yet
Milestone
No milestone
2 participants
@zanieb @jamesbraza