Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zero for empty decimal place for floats #7952

Closed
konstin opened this issue Oct 13, 2023 · 0 comments · Fixed by #7956
Closed

Add zero for empty decimal place for floats #7952

konstin opened this issue Oct 13, 2023 · 0 comments · Fixed by #7956
Assignees
@charliermarsh
Labels
bug Something isn't working formatter Related to the formatter good first issue Good for newcomers
Milestone
Formatter: Beta

Comments

@konstin
Copy link
Member

konstin commented Oct 13, 2023

Ours:

testcommon("%#.*g", (109, -1.e49 / 3.0))

Black:

testcommon("%#.*g", (109, -1.0e49 / 3.0))

We should add the zero for empty decimal place
@konstin konstin added bug Something isn't working good first issue Good for newcomers formatter Related to the formatter labels Oct 13, 2023
@charliermarsh charliermarsh mentioned this issue Oct 13, 2023
Merged
@charliermarsh charliermarsh self-assigned this Oct 13, 2023
charliermarsh added a commit that referenced this issue Oct 16, 2023
@charliermarsh
Add trailing zero between dot and exponential (#7956)
aa6846c 
Closes #7952.
@MichaReiser MichaReiser added this to the Formatter: Beta milestone Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
bug Something isn't working formatter Related to the formatter good first issue Good for newcomers
Projects
None yet
Milestone
Formatter: Beta
Development

Successfully merging a pull request may close this issue.

Add trailing zero between dot and exponential astral-sh/ruff
3 participants
@MichaReiser @charliermarsh @konstin