Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autofix error] RUF010 autofix fails when the expression is in parentheses, e.g. f"{(str(a))}" #4520

Closed
konstin opened this issue May 19, 2023 · 2 comments · Fixed by #4524
Closed

[Autofix error] RUF010 autofix fails when the expression is in parentheses, e.g. f"{(str(a))}" #4520

konstin opened this issue May 19, 2023 · 2 comments · Fixed by #4524
Labels
fixes Related to suggested fixes for violations

Comments

@konstin
Copy link
Member

konstin commented May 19, 2023

RUF010 creates an invalid autofix when the expression is already in parentheses, e.g.

f"{(str(a))}"

is replaced by

f"{(a!s)}"

which is invalid syntax.

Command:

ruff --no-cache --select RUF010 --fix code.py

ruff version fd16d65
@konstin konstin added the fixes Related to suggested fixes for violations label May 19, 2023
@JonathanPlasse
Copy link
Contributor

This version of RUF010 using libcst should not have this problem.
ec263ce (#4423)

@JonathanPlasse
Copy link
Contributor

I will make a PR soon.

@konstin konstin mentioned this issue May 19, 2023
Closed
@JonathanPlasse JonathanPlasse mentioned this issue May 19, 2023
Merged
MichaReiser pushed a commit that referenced this issue Jul 27, 2023
@minhrongcon2000
Make common::repr throw error instead of panic (#4520)
4bdc2d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixes Related to suggested fixes for violations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix RUF010 auto-fix with parenthesis JonathanPlasse/ruff
2 participants
@konstin @JonathanPlasse