lint.per-file-ignores option is ignored by the new language server

[DetachHead]

when enabling the new ruff.nativeServer setting in vscode, it seems to ignore tool.ruff.lint.per-file-ignores

# pyproject.toml

[tool.ruff.lint]
extend-select = ["S101"]
[tool.ruff.lint.per-file-ignores]
"tests/**/.py" = ["S101"]

// .vscode/settings.json

{
  "ruff.nativeServer": true
}

[charliermarsh]

I think you have a typo: "tests/**/.py" should be `"tests/**/*.py". Otherwise, it works in my testing.

[DetachHead]

oh oops! weird though because the old language server and the cli both seem to work with that glob

[DetachHead]

fixing that typo doesn't seem to work for me. it seems that the new lsp is only seeing the name of the file, but not the full path. "foo.py" works but "tests/foo.py" doesn't

[charliermarsh]

I'm not sure we can do. In the ruff-vscode repo, I added:

[tool.ruff.lint.per-file-ignores]
"tests/**/*.py" = ["F401"]

And F401 errors in ./tests/client/constants.py are successfully ignored, as are errors in ./tests/test_server.py.

[DetachHead]

i think it's because that repo does not use the new language server. adding the same thing to pyproject.toml, then adding "ruff.nativeServer": true to .vscode/settings.json causes the error to appear.

[charliermarsh]

Not for me... I have it enabled in my user settings, and I've verified that it's running via the logging. Could you be using an old Ruff version? There were some early versions of the native server that didn't support this.

[DetachHead]

according to the vscode extension log it's using 0.4.8:

2024-06-07 10:10:38.188 [info] Found ruff 0.4.8 at c:\Users\user\.vscode\extensions\charliermarsh.ruff-2024.26.0-win32-x64\bundled\libs\bin\ruff.exe

maybe it only happens on windows? i'm on windows 10, let me know if you need any more info

[charliermarsh]

I will try it on Windows, perhaps there's a difference there.

[charliermarsh]

Ok, I can successfully reproduce this on Windows.

[charliermarsh]

So the LSP file paths are now like:

/c%3A/Users/crmar/workspace/fastapi/tests/main.py

But the resolved ignore patterns are like:

c:\\Users\\crmar\\workspace\\fastapi\\tests\\**\\*.py