Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUF017 Autofix uses iadd but docs recommend iconcat #10088

Closed
nicodemus26 opened this issue Feb 22, 2024 · 0 comments · Fixed by #10666
Closed

RUF017 Autofix uses iadd but docs recommend iconcat #10088

nicodemus26 opened this issue Feb 22, 2024 · 0 comments · Fixed by #10666
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@nicodemus26
Copy link

nicodemus26 commented Feb 22, 2024

I could not find a substantive difference between iadd and iconcat in cpython aside from some narrower type contexts for iconcat. As the autofix uses iadd to resolve RUF017, I'd suggest updating the documents to match that behavior. If there is a significant difference, it would be helpful to call it out in the docs.

It may be helpful to mention the performance characteristics of the alternatives suggested, as observed here: #9045 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants