-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
10 changed files
with
274 additions
and
32 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,6 +36,7 @@ pub enum ScopeKind { | |
| Function(FunctionScope), | ||
| Generator, | ||
| Module, | ||
| Arg, | ||
| } | ||
|
|
||
| #[derive(Clone, Debug)] | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96 changes: 96 additions & 0 deletions
96
src/flake8_bugbear/plugins/function_call_argument_default.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| use rustpython_ast::{Arguments, Constant, Expr, ExprKind}; | ||
|
|
||
| use crate::ast::helpers::compose_call_path; | ||
| use crate::ast::types::{CheckLocator, Range}; | ||
| use crate::ast::visitor; | ||
| use crate::ast::visitor::Visitor; | ||
| use crate::check_ast::Checker; | ||
| use crate::checks::{Check, CheckKind}; | ||
| use crate::flake8_bugbear::plugins::mutable_argument_default::is_mutable_func; | ||
|
|
||
| const IMMUTABLE_FUNCS: [&str; 11] = [ | ||
| "tuple", | ||
| "frozenset", | ||
| "operator.attrgetter", | ||
| "operator.itemgetter", | ||
| "operator.methodcaller", | ||
| "attrgetter", | ||
| "itemgetter", | ||
| "methodcaller", | ||
| "types.MappingProxyType", | ||
| "MappingProxyType", | ||
| "re.compile", | ||
| ]; | ||
|
|
||
| fn is_immutable_func(expr: &Expr) -> bool { | ||
| compose_call_path(expr).map_or_else(|| false, |func| IMMUTABLE_FUNCS.contains(&func.as_str())) | ||
| } | ||
|
|
||
| struct ArgumentDefaultVisitor { | ||
| checks: Vec<(CheckKind, Range)>, | ||
| } | ||
|
|
||
| impl<'a, 'b> Visitor<'b> for ArgumentDefaultVisitor | ||
| where | ||
| 'b: 'a, | ||
| { | ||
| fn visit_expr(&mut self, expr: &'a Expr) { | ||
| match &expr.node { | ||
| ExprKind::Call { func, args, .. } => { | ||
| if !is_mutable_func(func) | ||
| && !is_immutable_func(func) | ||
| && !is_nan_or_infinity(func, args) | ||
| { | ||
| self.checks.push(( | ||
| CheckKind::FunctionCallArgumentDefault, | ||
| Range::from_located(expr), | ||
| )) | ||
| } | ||
| visitor::walk_expr(self, expr) | ||
| } | ||
| ExprKind::Lambda { .. } => {} | ||
| _ => visitor::walk_expr(self, expr), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| fn is_nan_or_infinity(expr: &Expr, args: &[Expr]) -> bool { | ||
| if let ExprKind::Name { id, .. } = &expr.node { | ||
| if id == "float" { | ||
| if let Some(arg) = args.first() { | ||
| if let ExprKind::Constant { | ||
| value: Constant::Str(value), | ||
| .. | ||
| } = &arg.node | ||
| { | ||
| let lowercased = value.to_lowercase(); | ||
| return lowercased == "nan" | ||
| || lowercased == "+nan" | ||
| || lowercased == "-nan" | ||
| || lowercased == "inf" | ||
| || lowercased == "+inf" | ||
| || lowercased == "-inf" | ||
| || lowercased == "infinity" | ||
| || lowercased == "+infinity" | ||
| || lowercased == "-infinity"; | ||
| } | ||
| } | ||
| } | ||
| } | ||
| false | ||
| } | ||
|
|
||
| /// B008 | ||
| pub fn function_call_argument_default(checker: &mut Checker, arguments: &Arguments) { | ||
| let mut visitor = ArgumentDefaultVisitor { checks: vec![] }; | ||
| for expr in arguments | ||
| .defaults | ||
| .iter() | ||
| .chain(arguments.kw_defaults.iter()) | ||
| { | ||
| visitor.visit_expr(expr); | ||
| } | ||
| for (check, range) in visitor.checks { | ||
| checker.add_check(Check::new(check, checker.locate_check(range))); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.