Skip to content

Commit

Permalink
Mark unsafe
Browse files Browse the repository at this point in the history
  • Loading branch information
@charliermarsh
charliermarsh committed Oct 11, 2023
1 parent 5e2fbd5 commit d093651
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 30 deletions.
4 changes: 2 additions & 2 deletions crates/ruff_linter/src/rules/pylint/rules/repeated_equality_comparison.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ impl AlwaysFixableViolation for RepeatedEqualityComparison {
}

fn fix_title(&self) -> String {
format!("Consider merging multiple comparisons. Use a `set` if the elements are hashable.")
format!("Merge multiple comparisons")
}
}

Expand Down Expand Up @@ -148,7 +148,7 @@ pub(crate) fn repeated_equality_comparison(checker: &mut Checker, bool_op: &ast:
range: bool_op.range(),
}));

diagnostic.set_fix(Fix::safe_edit(Edit::range_replacement(
diagnostic.set_fix(Fix::unsafe_edit(Edit::range_replacement(
content,
bool_op.range(),
)));
Expand Down
56 changes: 28 additions & 28 deletions ...snapshots/ruff_linter__rules__pylint__tests__PLR1714_repeated_equality_comparison.py.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ repeated_equality_comparison.py:2:1: PLR1714 [*] Consider merging multiple compa
3 |
4 | foo != "a" and foo != "b"
|
= help: Consider merging multiple comparisons. Use a `set` if the elements are hashable.
= help: Merge multiple comparisons

ℹ Fix
ℹ Suggested fix
1 1 | # Errors.
2 |-foo == "a" or foo == "b"
2 |+foo in ("a", "b")
Expand All @@ -28,9 +28,9 @@ repeated_equality_comparison.py:4:1: PLR1714 [*] Consider merging multiple compa
5 |
6 | foo == "a" or foo == "b" or foo == "c"
|
= help: Consider merging multiple comparisons. Use a `set` if the elements are hashable.
= help: Merge multiple comparisons

ℹ Fix
ℹ Suggested fix
1 1 | # Errors.
2 2 | foo == "a" or foo == "b"
3 3 |
Expand All @@ -49,9 +49,9 @@ repeated_equality_comparison.py:6:1: PLR1714 [*] Consider merging multiple compa
7 |
8 | foo != "a" and foo != "b" and foo != "c"
|
= help: Consider merging multiple comparisons. Use a `set` if the elements are hashable.
= help: Merge multiple comparisons

ℹ Fix
ℹ Suggested fix
3 3 |
4 4 | foo != "a" and foo != "b"
5 5 |
Expand All @@ -70,9 +70,9 @@ repeated_equality_comparison.py:8:1: PLR1714 [*] Consider merging multiple compa
9 |
10 | foo == a or foo == "b" or foo == 3 # Mixed types.
|
= help: Consider merging multiple comparisons. Use a `set` if the elements are hashable.
= help: Merge multiple comparisons

ℹ Fix
ℹ Suggested fix
5 5 |
6 6 | foo == "a" or foo == "b" or foo == "c"
7 7 |
Expand All @@ -91,9 +91,9 @@ repeated_equality_comparison.py:10:1: PLR1714 [*] Consider merging multiple comp
11 |
12 | "a" == foo or "b" == foo or "c" == foo
|
= help: Consider merging multiple comparisons. Use a `set` if the elements are hashable.
= help: Merge multiple comparisons

ℹ Fix
ℹ Suggested fix
7 7 |
8 8 | foo != "a" and foo != "b" and foo != "c"
9 9 |
Expand All @@ -112,9 +112,9 @@ repeated_equality_comparison.py:12:1: PLR1714 [*] Consider merging multiple comp
13 |
14 | "a" != foo and "b" != foo and "c" != foo
|
= help: Consider merging multiple comparisons. Use a `set` if the elements are hashable.
= help: Merge multiple comparisons

ℹ Fix
ℹ Suggested fix
9 9 |
10 10 | foo == a or foo == "b" or foo == 3 # Mixed types.
11 11 |
Expand All @@ -133,9 +133,9 @@ repeated_equality_comparison.py:14:1: PLR1714 [*] Consider merging multiple comp
15 |
16 | "a" == foo or foo == "b" or "c" == foo
|
= help: Consider merging multiple comparisons. Use a `set` if the elements are hashable.
= help: Merge multiple comparisons

ℹ Fix
ℹ Suggested fix
11 11 |
12 12 | "a" == foo or "b" == foo or "c" == foo
13 13 |
Expand All @@ -154,9 +154,9 @@ repeated_equality_comparison.py:16:1: PLR1714 [*] Consider merging multiple comp
17 |
18 | foo == bar or baz == foo or qux == foo
|
= help: Consider merging multiple comparisons. Use a `set` if the elements are hashable.
= help: Merge multiple comparisons

ℹ Fix
ℹ Suggested fix
13 13 |
14 14 | "a" != foo and "b" != foo and "c" != foo
15 15 |
Expand All @@ -175,9 +175,9 @@ repeated_equality_comparison.py:18:1: PLR1714 [*] Consider merging multiple comp
19 |
20 | foo == "a" or "b" == foo or foo == "c"
|
= help: Consider merging multiple comparisons. Use a `set` if the elements are hashable.
= help: Merge multiple comparisons

ℹ Fix
ℹ Suggested fix
15 15 |
16 16 | "a" == foo or foo == "b" or "c" == foo
17 17 |
Expand All @@ -196,9 +196,9 @@ repeated_equality_comparison.py:20:1: PLR1714 [*] Consider merging multiple comp
21 |
22 | foo != "a" and "b" != foo and foo != "c"
|
= help: Consider merging multiple comparisons. Use a `set` if the elements are hashable.
= help: Merge multiple comparisons

ℹ Fix
ℹ Suggested fix
17 17 |
18 18 | foo == bar or baz == foo or qux == foo
19 19 |
Expand All @@ -217,9 +217,9 @@ repeated_equality_comparison.py:22:1: PLR1714 [*] Consider merging multiple comp
23 |
24 | foo == "a" or foo == "b" or "c" == bar or "d" == bar # Multiple targets
|
= help: Consider merging multiple comparisons. Use a `set` if the elements are hashable.
= help: Merge multiple comparisons

ℹ Fix
ℹ Suggested fix
19 19 |
20 20 | foo == "a" or "b" == foo or foo == "c"
21 21 |
Expand All @@ -238,9 +238,9 @@ repeated_equality_comparison.py:24:1: PLR1714 [*] Consider merging multiple comp
25 |
26 | foo.bar == "a" or foo.bar == "b" # Attributes.
|
= help: Consider merging multiple comparisons. Use a `set` if the elements are hashable.
= help: Merge multiple comparisons

ℹ Fix
ℹ Suggested fix
21 21 |
22 22 | foo != "a" and "b" != foo and foo != "c"
23 23 |
Expand All @@ -259,9 +259,9 @@ repeated_equality_comparison.py:24:1: PLR1714 [*] Consider merging multiple comp
25 |
26 | foo.bar == "a" or foo.bar == "b" # Attributes.
|
= help: Consider merging multiple comparisons. Use a `set` if the elements are hashable.
= help: Merge multiple comparisons

ℹ Fix
ℹ Suggested fix
21 21 |
22 22 | foo != "a" and "b" != foo and foo != "c"
23 23 |
Expand All @@ -280,9 +280,9 @@ repeated_equality_comparison.py:26:1: PLR1714 [*] Consider merging multiple comp
27 |
28 | # OK
|
= help: Consider merging multiple comparisons. Use a `set` if the elements are hashable.
= help: Merge multiple comparisons

ℹ Fix
ℹ Suggested fix
23 23 |
24 24 | foo == "a" or foo == "b" or "c" == bar or "d" == bar # Multiple targets
25 25 |
Expand Down

0 comments on commit d093651

Please sign in to comment.