Revert JSON serializing content to null for deletions

astral-sh · Apr 11, 2023 · cff3d22 · cff3d22
1 parent fd31a7a
commit cff3d22
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/crates/ruff/src/message/json.rs b/crates/ruff/src/message/json.rs
@@ -73,7 +73,7 @@ impl Serialize for ExpandedEdits<'_> {
 
         for edit in self.edits {
             let value = json!({
-                "content": edit.content(),
+                "content": edit.content().unwrap_or_default(),
                 "location": edit.location(),
                 "end_location": edit.end_location()
             });

diff --git a/crates/ruff/src/message/snapshots/ruff__message__json__tests__output.snap b/crates/ruff/src/message/snapshots/ruff__message__json__tests__output.snap
@@ -25,7 +25,7 @@ expression: content
       "message": "Remove assignment to unused variable `x`",
       "edits": [
         {
-          "content": null,
+          "content": "",
           "location": {
             "row": 6,
             "column": 4

diff --git a/crates/ruff_cli/tests/integration_test.rs b/crates/ruff_cli/tests/integration_test.rs
@@ -96,7 +96,7 @@ fn test_stdin_json() -> Result<()> {
       "message": "Remove unused import: `os`",
       "edits": [
         {{
-          "content": null,
+          "content": "",
           "location": {{
             "row": 1,
             "column": 0