Use "application" scope for global only settings #594
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These two settings are only used from the global scope but can be defined at the workspace level. This PR updates the schema so that it's only visible in the "User" settings and not in the "Workspace" settings.
As seen in Ruff server implementation:
https://github.com/astral-sh/ruff/blob/a99832088a31b65f79e578e3131756cfdc0afb0d/crates/ruff_server/src/server.rs#L87-L95
And, we also don't have support for configuring the tracing setup for individual workspaces so it doesn't make sense either.
Reference
From https://code.visualstudio.com/api/references/contribution-points#contributes.configuration:
application
- Settings that apply to all instances of VS Code and can only be configured in user settings.window
- Windows (instance) specific settings which can be configured in user, workspace, or remote settings.Test Plan
Screen.Recording.2024-08-29.at.12.59.25.mov