Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "application" scope for global only settings #594

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Aug 29, 2024

Summary

These two settings are only used from the global scope but can be defined at the workspace level. This PR updates the schema so that it's only visible in the "User" settings and not in the "Workspace" settings.

As seen in Ruff server implementation:

https://github.com/astral-sh/ruff/blob/a99832088a31b65f79e578e3131756cfdc0afb0d/crates/ruff_server/src/server.rs#L87-L95

And, we also don't have support for configuring the tracing setup for individual workspaces so it doesn't make sense either.

Reference

From https://code.visualstudio.com/api/references/contribution-points#contributes.configuration:

  • application - Settings that apply to all instances of VS Code and can only be configured in user settings.
  • window - Windows (instance) specific settings which can be configured in user, workspace, or remote settings.

Test Plan

Screen.Recording.2024-08-29.at.12.59.25.mov

@dhruvmanila dhruvmanila added the configuration Related to settings and configuration label Aug 29, 2024
@T-256
Copy link

T-256 commented Aug 29, 2024

Use case for Workspace scope would be when someone wants to save ruff logs to different log files (e.g. ${folderName}-ruff.log). But since it's rare to this to happen, I agree to go up with this since ruff server already ignores workspace scope for these settings, and let's see if anyone will come up with this as an issue.

@dhruvmanila dhruvmanila merged commit f3ee65b into main Sep 2, 2024
6 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/global-settings branch September 2, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration Related to settings and configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants