Avoid erasing files when Ruff fails with an error #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/error
branch
from
87ffc37 to
e2f7590
Compare
MichaReiser
approved these changes
Dec 14, 2023
ruff_lsp/server.py
Outdated
| # For `ruff check`, 0 indicates successful completion with no remaining | ||
| # diagnostics, 1 indicates successful completion with remaining diagnostics, | ||
| # and 2 indicates an error. | ||
| if result.exit_code != 0 and result.exit_code != 1: |
There was a problem hiding this comment.
Nit: I don't know what's more idiomatic Python
Suggested change
| if result.exit_code != 0 and result.exit_code != 1: | |
| if not result.exit_code in [0, 1]: |
There was a problem hiding this comment.
😬
if result.exit_code not in [0, 1]:
...There was a problem hiding this comment.
I think not in (0, 1) is most idiomatic, probably.
There was a problem hiding this comment.
😬
if result.exit_code not in [0, 1]: ...
Python's hard
charliermarsh
force-pushed
the
charlie/error
branch
from
e2f7590 to
5ccbb89
Compare
dhruvmanila
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A user reported an issue in the VS Code extension (astral-sh/ruff#9123) in which their files were being erased on-save. The issue is that we don't check the exit code of all commands, and so if
ruff checkfails with an error, then we end up wiping the file entirely.This PR adds exit code-checking for all commands in the LSP. Further, we now surface such failures to the user directly (see bottom right):
Closes astral-sh/ruff#9123