Run tests against the main branch of Ruff #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
imho we should split the test matrix into running the test across all platforms and python versions and testing special cases which only run on select targets, such as min python and latest python on ubuntu-latest. |
|
@konstin I'm happy to make that change. Should we test latest or main across all targets? |
|
I'd say latest, i'd special case main, though it's not a strong preference. If we make main first then we should run CI on every commit of astra-sh/ruff first, though my main reason for latest over main is practicality, |
|
Great I agree! |
|
I've made the requested changes to the matrix — interestingly |
|
but it works locally... bigger hmm |
|
Forcing reinstall was the key — presumably because we don't do fancy versioning for development commits |
konstin
approved these changes
Oct 23, 2023
zanieb
added a commit
that referenced
this pull request
Oct 23, 2023
Uses the long ruff version if supported by the binary. Useful for testing e.g. #286 and astral-sh/ruff#8016 ``` ❯ pytest ======================================================================================================================================================= test session starts ======================================================================================================================================================== platform darwin -- Python 3.7.17, pytest-7.4.2, pluggy-1.2.0 ruff-version: 0.1.1+15 (860ffb954 2023-10-20) rootdir: /Users/mz/eng/src/astral-sh/ruff-lsp configfile: pyproject.toml plugins: typeguard-3.0.2, asyncio-0.21.1, anyio-3.7.1 asyncio: mode=strict collected 3 items tests/test_format.py . [ 33%] tests/test_server.py .. [100%] ======================================================================================================================================================== 3 passed in 0.68s ========================================================================================================================================================= ```
zanieb
added a commit
to astral-sh/ruff
that referenced
this pull request
Oct 23, 2023
Adds a CI job which runs `ruff-lsp` tests against the current Ruff build. Avoids rebuilding Ruff at the cost of running _after_ the cargo tests have finished. Might be worth the rebuild to get earlier feedback but I don't expect it to fail often? xref astral-sh/ruff-lsp#286 ## Test plan Verified use of the development version by inspecting version output in CI; supported by astral-sh/ruff-lsp#289 and #8034
azurelotus0926
added a commit
to azurelotus0926/ruff-lsp
that referenced
this pull request
Jun 27, 2024
Uses the long ruff version if supported by the binary. Useful for testing e.g. astral-sh/ruff-lsp#286 and astral-sh/ruff#8016 ``` ❯ pytest ======================================================================================================================================================= test session starts ======================================================================================================================================================== platform darwin -- Python 3.7.17, pytest-7.4.2, pluggy-1.2.0 ruff-version: 0.1.1+15 (860ffb954 2023-10-20) rootdir: /Users/mz/eng/src/astral-sh/ruff-lsp configfile: pyproject.toml plugins: typeguard-3.0.2, asyncio-0.21.1, anyio-3.7.1 asyncio: mode=strict collected 3 items tests/test_format.py . [ 33%] tests/test_server.py .. [100%] ======================================================================================================================================================== 3 passed in 0.68s ========================================================================================================================================================= ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests against ruff@main, installed from source.
The test matrix is kind of big here, we could drop Python versions or operating systems (for a subset of the matrix) but I'm not sure what subset is best. Since this repository is relatively calm, it might not hurt to just have a bunch of checks.Since this depends on us opening a pull request here to notice breakage with ruff, I'm also adding astral-sh/ruff#8016 which runs tests on each change to ruff.