Add a dedicated 'Ruff: Format document' action #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/format-action
branch
from
a6808ba to
794fc1f
Compare
|
Hmm, not sure how I feel about that. I see the consistency but I'm not aware that any other formatter exposes such a command. What's the use case for it? |
|
I guess the dedicated "Ruff: Fix all" is nice if you want to run just the Ruff fixes (as opposed to the generic "Fix all"). Perhaps there isn't really a use-case here for the formatter, apart from testing? Being able to run it without configuring it as your default formatter? |
|
Yeah, the fix all makes sense (does ruff has it's own |
|
Yeah, it defines a custom action in the VS Code client that triggers the server command defined in the LSP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We have this for lint fixing and import sorting. It seems consistent to have one for formatting too.