Sort code actions by specificity #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way code actions for specific diagnostic codes are suggested before more general ones like 'Fix: All' or 'Organize Imports'. See issue astral-sh#210 for discussions
|
Thanks! This makes sense. |
|
(I think this is small enough that we don't need dedicated tests for it. I'd typically do some manual testing via the VS Code extension.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It changes the sort order sent to clients. This way code actions for specific diagnostic codes are suggested before more general ones like 'Fix: All' or 'Organize Imports'.
See issue #210 for discussions
Test Plan
❔ I need help with this how you suggest to do it.