Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GEVD beamformer #520

Merged
merged 6 commits into from
Jun 30, 2021
Merged

Add GEVD beamformer #520

merged 6 commits into from
Jun 30, 2021

Conversation

ldelebec
Copy link
Contributor

GEVD beamformer is a kind of SDW MWF but computed in eigen space. It gives a good SIR but with less distortion than GEV beamformer.
The code is based on the one written by @nfurnon.

@mpariente
Copy link
Collaborator

Thank you for the PR !
I'll probably have a look next week, sorry for the delay.

Copy link
Collaborator

@mpariente mpariente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR !
Some minor comments to be addressed, but otherwise, it looks great 🙃

asteroid/dsp/beamforming.py Outdated Show resolved Hide resolved
asteroid/dsp/beamforming.py Outdated Show resolved Hide resolved
asteroid/dsp/beamforming.py Outdated Show resolved Hide resolved
asteroid/dsp/beamforming.py Outdated Show resolved Hide resolved
asteroid/dsp/beamforming.py Outdated Show resolved Hide resolved
tests/dsp/beamforming_test.py Show resolved Hide resolved
@mpariente mpariente merged commit 8f65027 into asteroid-team:master Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants