Skip to content
This repository has been archived by the owner on Dec 29, 2021. It is now read-only.

Change tempdir to tempfile in readme #93

Merged
merged 1 commit into from
Mar 15, 2018
Merged

Change tempdir to tempfile in readme #93

merged 1 commit into from
Mar 15, 2018

Conversation

Dylan-DPC-zz
Copy link

  • [n/A] I have created tests for any new feature, or added regression tests for bugfixes.
  • [n/A] cargo test succeeds
  • [n/A] Clippy is happy: cargo +nightly clippy succeeds
  • [n/A] Rustfmt is happy: cargo +nightly fmt succeeds

Closes #88

@epage
Copy link
Collaborator

epage commented Mar 14, 2018

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 14, 2018

🔒 Permission denied

Existing reviewers: click here to make epage a reviewer

@epage
Copy link
Collaborator

epage commented Mar 14, 2018

@killercup looks like I need permission again to do reviews.

@Dylan-DPC-zz Dylan-DPC-zz requested a review from epage March 14, 2018 20:27
@killercup
Copy link
Collaborator

killercup commented Mar 15, 2018 •
edited
Loading

What's wrong with tempdir? Is the migration to tempfile something that's happening ecosystem-wide?

(re-added you, @epage. bors seems to have not migrated the permissions with the github transfer)

@epage
Copy link
Collaborator

epage commented Mar 15, 2018

What's wrong with tempdir? Is the migration to tempfile something that's happening ecosystem-wide?

it looks like tempdir is being merged into tempfile
See rust-lang-deprecated/tempdir#45

@epage
Copy link
Collaborator

epage commented Mar 15, 2018

Oh, looks like the merge might not be complete

I was hoping we could wait until there's a published version of tempfile folks can immediately get before we do though.

@Stebalien do you have a plan in mind for the next release of tempfile? It would need to be a 3.0.0 wouldn't it, unless we go back and deprecate/shim the changed APIs on NamedTempFile.

And Stebalien/tempfile#43 for tempfile's merge

@Dylan-DPC-zz
Copy link
Author

Yes it isn't complete but it is fine to people to it from the start. We are just suggesting the crate so it doesn't harm anyone even though it hasn't been merged yet 😛 .

@epage
Copy link
Collaborator

epage commented Mar 15, 2018

Since this is just about recommending and not use, its probably fine to eagerly advertise tempfile.

bors r+

bors bot added a commit that referenced this pull request Mar 15, 2018
@bors
Merge #93
7052cb0 
93: Change tempdir to tempfile in readme r=epage a=Dylan-DPC

<!--
Thank you for taking the time to contribute to this project!

To ease reviewing your changes and making sure we don't forget anything,  please
take a minute to check the following (remove lines that don't apply), and
replace this text with a description of what this PR does. Bonus points for
linking to issues! :)
-->

- [n/A] I have created tests for any new feature, or added regression tests for bugfixes.
- [n/A] `cargo test` succeeds
- [n/A] Clippy is happy: `cargo +nightly clippy` succeeds
- [n/A] Rustfmt is happy: `cargo +nightly fmt` succeeds

Closes #88
@bors
Copy link
Contributor

bors bot commented Mar 15, 2018

Build succeeded

@bors bors bot merged commit 682853b into master Mar 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@epage epage epage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update readme to point to tempfile rather than tempdir
4 participants
@Dylan-DPC-zz @epage @killercup @Dylan-DPC