-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: unified logs handler #1031
Feature: unified logs handler #1031
Conversation
- Add CustomLogsHandler for unified logging - Implement JSON and text file logging - Add comprehensive test coverage for logging functionality - Update pytest configuration for async tests - Update gitignore patterns for log files
Welcome @kga245, |
Thanks, Elisha.
LMK if you have any questions. I don't know if you saw my comments in the thread on discord but I left a loom describing how the changes work there as well. HTH.
…On Dec 18, 2024 at 10:33 PM -0800, Elisha Kramer ***@***.***>, wrote:
Welcome @kga245,
Wow, this looks awesome!
I'll start with having a look at the changes in the frontend and tests folders in the near future
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This was cruff from a different branch I was working on. My bad.
I noticed that if you do a very long query the file names that get generated can be larger than the host permits. So I added some truncation that should work pretty universally to limit the file name to under <250 characters total including the important naming convention of the prefixes.
@kga245 this is huge! Will review as well, can you point me the to the loom recording? |
@ElishaKay I reviewed and looks great. Would you mind giving it another run + local testing and approve? |
Great news about the merge. Thanks for that. @assafelovic here's the loom: https://www.loom.com/share/873efd40fe944bf68cfc9bf8a19ccdb1?sid=bcb36490-569a-4cb8-b7b9-b48a789358af @ElishaKay I noticed the edits you made. I have a slight change to add today. I will commit, test and submit another PR which will leave your changes in tact. Adding back the log button for detailed reports. I am also working on documentation for the logs so users will know how to work with them. Question: I notice the copy to markdown button doesn't actually copy markdown (seems to be plain text). Considering we have a download markdown button should we consider just dropping the copy markdown button altogether? If not, then I might work on a change to change the download buttons to a dropdown select instead so we can fit in more download types without cluttering the UI. I think a download log as CSV and download log as markdown might also be useful to some useers. LMK what you prefer. |
Log Handler Restructuring and Feature Enhancements
Overview
This PR implements several improvements focused on:
Changes
Backend
backend/server/app.py
)Frontend
frontend/nextjs/components/ResearchBlocks/AccessReport.tsx
)Testing & Infrastructure
tests/gptr-logs-handler.py
,tests/report-types.py
)CustomLogsHandler
to shared module (src.logs_handler
)Development Workflow
.gitignore
)logs/
).orig
) - developer preferenceBenefits
UATs
Manual Testing Checklist
getReportLink()
correctly handles different path formatsNotes
CORS Testing (Future)