fix: Add language parameter support to generate_subtopic_report_prompt #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…language setting Signed-off-by: Taylor Dolezal <[email protected]>
|
great fix that works for me, please consider merge asap |
assafelovic
approved these changes
Dec 18, 2024
|
Thank you! |
|
FYI I found another bug, but for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#1026 introduced a TypeError when generating subtopic reports due to a missing
languageparameter in thegenerate_subtopic_report_promptfunction and causes rearch reports to fail.Error message: