This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
Fix for publishing issue with RIDs #3182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| stream.Write(buffer, 0, buffer.Length); | ||
|
|
||
| // Read the response | ||
| byte[] readbuffer = new byte[1024]; |
There was a problem hiding this comment.
Can you just use StreaemReader.ReadToEnd here?
There was a problem hiding this comment.
This code was actually taken from a different test which was trying to repro a bug in System.Net.Security around StreamReader.ReadToEnd :). I can trim it back since we don't care about that here.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a candidate fix for the publishing issue with RIDs. I verified that it fixes the problem in my repro. I still need to go through it and tidy it up a bit though.
fixes #3183
/cc @davidfowl @muratg @ericstj @DamianEdwards @danroth27 @Eilon