This repository has been archived by the owner on Nov 22, 2018. It is now read-only.
Add an option to specify the max response size cached #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// <summary> | ||
| /// The largest cacheable size for the response body in bytes. | ||
| /// </summary> | ||
| public int? MaximumCachedBodySize { get; set; } |
There was a problem hiding this comment.
Should we specify a default size? Also could consider the naming MaximumCacheableBodySize or MaximumBodySizeToCache.
There was a problem hiding this comment.
long, not int?. Default to 1mb for starters?
|
🆙📅 |
|
FYI: It looks like MemoryStream.Dispose doesn't actually free the memory. You need to call SetLength and Capacity to shrink it. |
|
|
JunTaoLuo
force-pushed
the
johluo/max-response-size
branch
from
f17c732 to
d72ef12
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tratcher @davidfowl