This repository has been archived by the owner on Nov 22, 2018. It is now read-only.
Conditional requests #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
force-pushed
the
johluo/conditional-requests
branch
from
1382273 to
2c1b708
Compare
| if (ConditionalRequestSatisfied(cachedResponseHeaders)) | ||
| { | ||
| _httpContext.Response.StatusCode = StatusCodes.Status304NotModified; | ||
| return true; |
There was a problem hiding this comment.
inconsistent use of responseServed vs return true.
There was a problem hiding this comment.
I had the responseServed variable previously because we couldn't short-circuit after failing to serve a response due to the OnlyIfCached header. The conditional requests are different, if we served that, we can return right away. But I guess for consistency, I can just keep using responseServed and return it at the end. This means one extra check on the boolean even after satisfying the conditional request but I guess that's fine.
JunTaoLuo
force-pushed
the
johluo/conditional-requests
branch
from
eb8426a to
916d12e
Compare
|
🆙📅 |
| { | ||
| foreach (var tag in ifNoneMatchHeader) | ||
| { | ||
| // TODO: use strong comparison |
|
|
JunTaoLuo
force-pushed
the
johluo/conditional-requests
branch
from
916d12e to
52f219b
Compare
|
Only |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to send 304 responses for requests conditional on
IfModifiedSinceandIfNoneMatch.cc @Tratcher @davidfowl