Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Expose FilePath on MappingLocation to let Razor editor know mapping origination. #552

Closed
NTaylorMullen opened this issue Sep 29, 2015 · 4 comments
Assignees
Milestone

Comments

@NTaylorMullen
Copy link
Contributor

Today the Razor editor has to jump through hoops to determine if a projected mapping location originated from the current file or from a _ViewImports.cshtml. Due to their roundabout way of determining a mappings original location it can occasionally be wrong. We should expose what file created the mapping location so tooling can respond accordingly.

/cc @pranavkm @ToddGrun

@Eilon
Copy link
Member

Eilon commented Sep 29, 2015

Do we need to have a matching tooling bug to consume this new property?

@NTaylorMullen
Copy link
Contributor Author

@ToddGrun already has one 😄

@Eilon Eilon added this to the 4.0.0-rc1 milestone Sep 29, 2015
@Eilon
Copy link
Member

Eilon commented Sep 29, 2015

Cool.

NTaylorMullen added a commit that referenced this issue Oct 16, 2015
- We had the `FilePath` information available to us but we weren't exposing it on the `MappingLocation` context object.
- By exposing the `FilePath` the Razor editor can 100% know where a `MappingLocation` is resolved from. If `null` the location is deemed to be the current source/generated file.

#552
NTaylorMullen added a commit that referenced this issue Oct 20, 2015
- We had the `FilePath` information available to us but we weren't exposing it on the `MappingLocation` context object.
- By exposing the `FilePath` the Razor editor can 100% know where a `MappingLocation` is resolved from. If `null` the location is deemed to be the current source/generated file.

#552
@NTaylorMullen
Copy link
Contributor Author

be324b2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants