Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Revive call to FormattingUtilities in XmlDataContractSerializerOutputFormatter #6511

Merged
merged 1 commit into from
Jul 7, 2017
Merged

Revive call to FormattingUtilities in XmlDataContractSerializerOutputFormatter #6511

merged 1 commit into from
Jul 7, 2017

Conversation

pranavkm
Copy link
Contributor

@pranavkm pranavkm commented Jul 7, 2017

Fixes #6235

@pranavkm pranavkm requested review from rynowak and dougbu July 7, 2017 00:51
dougbu
dougbu approved these changes Jul 7, 2017
View reviewed changes
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated code looks right. But, update #6235 to clearly indicate the FormattingUtilities call's removal was papering over a test bug.

@pranavkm pranavkm merged commit fc106ab into dev Jul 7, 2017
@pranavkm pranavkm deleted the prkrishn/formatting branch July 7, 2017 17:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dougbu dougbu dougbu approved these changes

@rynowak rynowak rynowak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pranavkm @rynowak @dougbu @dnfclas