This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Transition SelectTagHelper and OptionTagHelper to use context.Items.
#3392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @dougbu |
| @@ -54,7 +54,7 @@ public override int Order | |||
|
|
|||
| /// <inheritdoc /> | |||
| /// <remarks> | |||
| /// Does nothing unless <see cref="FormContext.FormData"/> contains a | |||
| /// Does nothing unless <see cref="TagHelperContext.Items"/> contains a | |||
| /// <see cref="SelectTagHelper.SelectedValuesFormDataKey"/> entry and that entry is a non-empty | |||
There was a problem hiding this comment.
Throw SelectTagHelper.SelectedValuesFormDataKey away -- far away. This is an inefficient pattern that Items was designed to avoid. Instead use typeof(SelectTagHelper).
|
⌚ |
|
Updated. |
| @@ -131,7 +121,7 @@ public override void Process(TagHelperContext context, TagHelperOutput output) | |||
|
|
|||
| // Whether or not (not being highly unlikely) we generate anything, could update contained <option/> | |||
| // elements. Provide selected values for <option/> tag helpers. They'll run next. | |||
| ViewContext.FormContext.FormData[SelectedValuesFormDataKey] = currentValues; | |||
| context.Items[typeof(SelectTagHelper)] = currentValues; | |||
There was a problem hiding this comment.
This will need to move to new Init() method as part of your reaction PR. Could you rebase that branch on top of this one? Or is that almost ready to get in first?
There was a problem hiding this comment.
Now Init()s in, this should be there.
|
⌚ |
NTaylorMullen
force-pushed
the
nimullen/selecttaghelper.3347
branch
from
f99e45f to
96421a5
Compare
|
Updated. |
| /// Thrown if <see cref="Items"/> is non-<c>null</c> but <see cref="For"/> is <c>null</c>. | ||
| /// </exception> | ||
| public override void Process(TagHelperContext context, TagHelperOutput output) | ||
| public override void Init(TagHelperContext context) |
|
|
but may want to wait for Coherence to catch up since we can't confirm MVC builds at the moment.
NTaylorMullen
force-pushed
the
nimullen/selecttaghelper.3347
branch
from
96421a5 to
24b16f0
Compare
…ems`. - Added functional tests to validate data created from a `SelectTagHelper` does not impact following `<select>` tags. - Also moved the new `SelectTagHelper` communication flow into `TagHelper.Init`. #3347
NTaylorMullen
force-pushed
the
nimullen/selecttaghelper.3347
branch
from
24b16f0 to
911dfc5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SelectTagHelperdoes not impact following<select>tags.TagHelper and non-TagHelper select tags in a form don't work well together. #3347