This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Added Step attribute to number input type #2795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return GenerateTextBox(htmlHelper, inputType: "number"); | ||
| var htmlAttributes = | ||
| CreateHtmlAttributes(htmlHelper, className: "text-box single-line", inputType: "number"); | ||
| htmlAttributes["step"] = "any"; |
There was a problem hiding this comment.
I thought this was needed for only decimal-enabled types: float, double, and decimal. For integral types there's no step needed, right?
There was a problem hiding this comment.
Plus, the code here now looks more "complicated" because it seems to slightly duplicate some existing logic...
There was a problem hiding this comment.
You are right. I was investigating #2780 and it is possible that we might not even need this change based on what we decide for that scenario.
|
Closing this PR since we decided to use |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - #2712
@dougbu