Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Rename ModelState (the type) -> ModelStateEntry #3326

Closed
rynowak opened this issue Oct 15, 2015 · 3 comments
Closed

Rename ModelState (the type) -> ModelStateEntry #3326

rynowak opened this issue Oct 15, 2015 · 3 comments
Assignees
Milestone

Comments

@rynowak
Copy link
Member

rynowak commented Oct 15, 2015

See: #3315

ModelState (the type) rarely appears in user-code. Users will generally interact with the MSD directly using AddModelError or something similar. Seeing ModelState (the type) in user-code is usually a mistake. We should rename it raise our sanity level and prevent mistake-making by future generations of humans and cyborgs alike.

@Eilon
Copy link
Member

Eilon commented Oct 15, 2015

A cyborg would never make this mistake.

@Eilon
Copy link
Member

Eilon commented Oct 21, 2015

Done? 😄

@dougbu
Copy link
Member

dougbu commented Oct 21, 2015

A cyborg would never make this mistake.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants